Add comprehensive tests for books functionality #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds 8 new tests for the books functionality: - Resolver structure validation - books query (returns array, correct structure, field selection) - book(id) query (single book, non-existent id returns null) - addBook mutation (creates book, created book can be retrieved) Total test count: 18 (was 10) Closes #14
- Update node.js.yml to test on Node 20.x and 22.x (required by Apollo Server 5 and Prisma 7) - Add npm cache for faster CI - Add prisma generate step before tests - Update actions/checkout and actions/setup-node to v4 - Update codeql-action to v3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #14 - "This ain't got no tests!"
This PR adds comprehensive test coverage for the books functionality, which was previously untested.
New Tests Added (8 tests)
Resolver Structure
books,book,addBook)Query Tests
booksquery returns an arraybooksquery returns books with correct structure (id, title, author)book(id)query returns a single book by IDbook(id)query returns null for non-existent IDMutation Tests
addBookmutation creates a new book with correct databook(id)queryTest Results
Test Plan
Closes #14